Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dask_awkward.without_field #508

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

ikrommyd
Copy link
Contributor

Title explains everything

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.03%. Comparing base (8cb8994) to head (3a38bf6).
Report is 85 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
- Coverage   93.06%   93.03%   -0.04%     
==========================================
  Files          23       23              
  Lines        3290     3343      +53     
==========================================
+ Hits         3062     3110      +48     
- Misses        228      233       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ikrommyd ikrommyd changed the title feat: add ak.without_field feat: add dask_awkward.without_field May 31, 2024
@martindurant
Copy link
Collaborator

FAILED tests/test_behavior.py::test_distance_behavior - AssertionError

looks like some floating point inaccuracy

@martindurant
Copy link
Collaborator

(passed on rerun)

@ikrommyd
Copy link
Contributor Author

#506 Thought that this was just the problem.

@martindurant
Copy link
Collaborator

#506 Thought that this was just the problem.

Right, to be fixed somehow...

@martindurant martindurant merged commit ca79566 into dask-contrib:main Jun 4, 2024
25 checks passed
@ikrommyd ikrommyd deleted the add-without-field branch June 4, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants